-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: channel can use custom serializer #3711
Conversation
🚅 Previously deployed to Railway in the core project. Environment has been deleted. |
/next |
🎉 PR Next publish successful!
|
/next |
🎉 PR Next publish successful!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3711 +/- ##
==========================================
- Coverage 55.41% 55.41% -0.01%
==========================================
Files 1530 1536 +6
Lines 93306 93390 +84
Branches 19154 19172 +18
==========================================
+ Hits 51710 51756 +46
- Misses 34497 34536 +39
+ Partials 7099 7098 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/next |
🎉 PR Next publish successful!
|
packages/connection/__test__/common/fury-extends/one-of.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
Codeblitz 接入的话,前后端通信不需要进行序列化。
现在 rpc 默认使用 fury 序列化,在 codeblitz 这种纯前端的,也会序列化一遍。
之前 codeblitz 是重写了 RPCSeriviceCenter,其实没必要,只要 opensumi 支持一下自定义 serializer 就行
Changelog
use custom serializer for wschannel and rpc