Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: channel can use custom serializer #3711

Merged
merged 15 commits into from
May 31, 2024
Merged

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented May 23, 2024

Types

  • 🪚 Refactors

Background or solution

Codeblitz 接入的话,前后端通信不需要进行序列化。

现在 rpc 默认使用 fury 序列化,在 codeblitz 这种纯前端的,也会序列化一遍。
之前 codeblitz 是重写了 RPCSeriviceCenter,其实没必要,只要 opensumi 支持一下自定义 serializer 就行

Changelog

use custom serializer for wschannel and rpc

Copy link

railway-app bot commented May 23, 2024

🚅 Previously deployed to Railway in the core project. Environment has been deleted.

@opensumi opensumi bot added the ⚙️ refactor Refactor code label May 23, 2024
@bytemain
Copy link
Member Author

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 29, 2024

🎉 PR Next publish successful!

3.0.4-next-1716962745.0

@bytemain
Copy link
Member Author

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 29, 2024

🎉 PR Next publish successful!

3.0.4-next-1716970216.0

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 69.19431% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 55.41%. Comparing base (7596f43) to head (d18b853).
Report is 2 commits behind head on main.

Files Patch % Lines
packages/connection/src/common/rpc/message-io.ts 69.56% 14 Missing ⚠️
packages/connection/src/common/ws-channel.ts 51.72% 12 Missing and 2 partials ⚠️
...ages/core-browser/src/application/runtime/index.ts 33.33% 11 Missing and 1 partial ⚠️
...ore-browser/src/application/runtime/base-socket.ts 64.28% 4 Missing and 1 partial ⚠️
packages/core-browser/src/bootstrap/app.ts 37.50% 5 Missing ⚠️
...ages/connection/src/common/rpc-service/registry.ts 40.00% 2 Missing and 1 partial ⚠️
...kages/connection/src/browser/ws-channel-handler.ts 83.33% 2 Missing ⚠️
packages/connection/src/common/rpc/connection.ts 88.88% 2 Missing ⚠️
packages/connection/src/common/serializer/index.ts 83.33% 2 Missing ⚠️
packages/connection/src/common/serializer/raw.ts 33.33% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3711      +/-   ##
==========================================
- Coverage   55.41%   55.41%   -0.01%     
==========================================
  Files        1530     1536       +6     
  Lines       93306    93390      +84     
  Branches    19154    19172      +18     
==========================================
+ Hits        51710    51756      +46     
- Misses      34497    34536      +39     
+ Partials     7099     7098       -1     
Flag Coverage Δ
jsdom 50.86% <62.08%> (+<0.01%) ⬆️
node 15.58% <68.24%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain
Copy link
Member Author

/next

@opensumi
Copy link
Contributor

opensumi bot commented May 29, 2024

🎉 PR Next publish successful!

3.0.4-next-1716974737.0

@bytemain bytemain changed the title WIP: refactor: channel can use custom serializer refactor: channel can use custom serializer May 29, 2024
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit eb42316 into main May 31, 2024
12 checks passed
@bytemain bytemain deleted the refactor/update-connection branch May 31, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants