Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not restore diff editor state #3850

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jul 15, 2024

Types

  • 🐛 Bug Fixes

Background or solution

当前 Diff 编辑器的状态恢复存在问题,来回切换会导致光标位置乱跳问题,临时处理一下,后续仍是一个需要解决的问题

Changelog

not restore diff editor state

Summary by CodeRabbit

  • 改进
    • 移除了不必要的 LRUCache 导入和 this.restoreState() 调用,以优化代码性能。

@erha19 erha19 requested review from bytemain and Ricbet July 15, 2024 02:30
Copy link

railway-app bot commented Jul 15, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

Copy link
Contributor

coderabbitai bot commented Jul 15, 2024

Walkthrough

这次修改主要集中在BrowserDiffEditor类中,删除了对LRUCache的导入以及else块内的this.restoreState()调用。

Changes

文件路径 修改摘要
packages/editor/src/.../editor-collection.service.ts 删除了LRUCache导入和this.restoreState()调用

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (3e0fe4e) to head (83ecadd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3850   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files        1556     1557    +1     
  Lines       94800    94811   +11     
  Branches    19406    19408    +2     
=======================================
+ Hits        52132    52141    +9     
- Misses      35451    35454    +3     
+ Partials     7217     7216    -1     
Flag Coverage Δ
jsdom 50.43% <ø> (+<0.01%) ⬆️
node 15.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit b6cfd7d into main Jul 23, 2024
13 checks passed
@bytemain bytemain deleted the fix/not-restore-diff-editor-state branch July 23, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants