-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: platform detection after Node.js 21 #3956
Conversation
🚅 Previously deployed to Railway in the core project. Environment has been deleted. |
Walkthrough本次更改主要集中在两个方面:首先,修改了 macOS 终端设置中 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Terminal
participant NodeProcess
User->>Terminal: 启动终端
Terminal->>NodeProcess: 检查环境
NodeProcess->>Terminal: 返回环境信息
Terminal->>Terminal: 处理终端参数
Terminal->>User: 启动终端会话
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
}; | ||
type?: string; | ||
} | ||
declare const process: INodeProcess; | ||
declare const global: any; | ||
|
||
let nodeProcess: INodeProcess | undefined; | ||
if (typeof process !== 'undefined' && typeof process?.versions?.node === 'string') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3.2 #3956 +/- ##
==========================================
+ Coverage 54.75% 54.89% +0.13%
==========================================
Files 1561 1566 +5
Lines 96435 95563 -872
Branches 19973 19597 -376
==========================================
- Hits 52804 52458 -346
+ Misses 36130 35790 -340
+ Partials 7501 7315 -186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Types
Background or solution
Node.js v21 后新增了 navigator 符号:
Changelog