Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support problem fix api #3999

Merged
merged 4 commits into from
Sep 11, 2024
Merged

feat: support problem fix api #3999

merged 4 commits into from
Sep 11, 2024

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Sep 6, 2024

Types

  • 🎉 New Features

Background or solution

image

hover_fix.mp4

Changelog

新增 registerProblemFixFeature API 支持 hover fix with AI

Summary by CodeRabbit

Summary by CodeRabbit

  • 新功能

    • 引入问题修复功能,允许应用程序提供AI驱动的修复建议。
    • 新增问题修复组件,用户可以通过按钮触发修复操作。
    • 增加本地化支持,提供英语和中文的“修复与AI”标题。
  • 文档

    • 更新了能力接口,支持问题修复功能的声明。
  • 样式

    • 添加了问题修复按钮的样式,确保其在用户界面中的可见性和可交互性。

Copy link

railway-app bot commented Sep 6, 2024

This PR was not deployed automatically as @Ricbet does not have access to the Railway project.

In order to get automatic PR deploys, please add @Ricbet to the project inside the project settings page.

Copy link
Contributor

coderabbitai bot commented Sep 6, 2024

Walkthrough

此次更改引入了一个新的问题修复功能,涉及多个文件的更新。主要包括在 AINativeBrowserContribution 类中添加了 ProblemFixHandler 依赖项,以及新的 React 组件 ProblemFixComponent 的实现。此外,创建了 ProblemFixProviderRegistryProblemFixService,用于管理和提供问题修复功能。还更新了本地化支持以适应新功能。

Changes

文件路径 更改摘要
packages/ai-native/src/browser/... AINativeBrowserContributionAIEditorContribution 中添加 ProblemFixHandler,更新相关方法以支持问题修复。
packages/ai-native/src/browser/contrib/problem-fix/... 新增 problem-fix.component.tsx 实现问题修复的 React 组件,新增 problem-fix.feature.registry.ts 定义问题修复提供者注册表,新增 problem-fix.handler.ts 实现自定义 Monaco 编辑器悬停参与者,新增 problem-fix.service.ts 提供问题修复服务。
packages/ai-native/src/browser/contrib/problem-fix/... 新增 problem-fix.module.less 定义问题修复按钮的样式。
packages/ai-native/src/browser/index.ts 更新导入和依赖注入配置,整合问题修复功能。
packages/ai-native/src/browser/types.ts 新增 IProblemFixProviderRegistry 接口,更新 AINativeCoreContribution 接口以支持问题修复功能。
packages/core-browser/src/ai-native/ai-config.service.ts 更新 IAINativeCapabilities 以支持问题修复功能。
packages/core-common/src/types/ai-native/index.ts IAINativeCapabilities 中新增 supportsProblemFix 属性。
packages/i18n/src/common/en-US.lang.ts 在本地化文件中新增英文字符串 'Fix with AI'
packages/i18n/src/common/zh-CN.lang.ts 在本地化文件中新增中文字符串 'AI 修复'
packages/startup/entry/sample-modules/ai-native/... AINativeContribution 中新增 registerProblemFixFeature 方法以注册问题修复功能。

Tip

Announcements
  • The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
  • We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f6f5833 and 81b9337.

Files selected for processing (2)
  • packages/ai-native/src/browser/contrib/problem-fix/problem-fix.component.tsx (1 hunks)
  • packages/ai-native/src/browser/contrib/problem-fix/problem-fix.handler.ts (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • packages/ai-native/src/browser/contrib/problem-fix/problem-fix.component.tsx
  • packages/ai-native/src/browser/contrib/problem-fix/problem-fix.handler.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@opensumi opensumi bot added 🎨 feature feature required 🐞 bug Something isn't working labels Sep 6, 2024
@Ricbet Ricbet changed the title WIP: feat: support problem fix components WIP: feat: support problem fix api Sep 6, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 3.53982% with 109 lines in your changes missing coverage. Please review.

Project coverage is 54.48%. Comparing base (c7bbf3b) to head (81b9337).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...browser/contrib/problem-fix/problem-fix.handler.ts 0.00% 61 Missing and 7 partials ⚠️
.../browser/widget/inline-chat/inline-chat.handler.ts 0.00% 22 Missing and 4 partials ⚠️
...browser/contrib/problem-fix/problem-fix.service.ts 0.00% 7 Missing ⚠️
...ontrib/problem-fix/problem-fix.feature.registry.ts 0.00% 6 Missing ⚠️
packages/ai-native/src/browser/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3999      +/-   ##
==========================================
- Coverage   54.52%   54.48%   -0.05%     
==========================================
  Files        1580     1583       +3     
  Lines       96733    96828      +95     
  Branches    19808    19819      +11     
==========================================
+ Hits        52743    52752       +9     
- Misses      36537    36614      +77     
- Partials     7453     7462       +9     
Flag Coverage Δ
jsdom 49.99% <3.53%> (-0.04%) ⬇️
node 15.61% <3.53%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet force-pushed the feat/support-problem-fix-api branch from 8282f0e to e6fa620 Compare September 9, 2024 08:59
@Ricbet Ricbet changed the title WIP: feat: support problem fix api feat: support problem fix api Sep 10, 2024
@Ricbet
Copy link
Member Author

Ricbet commented Sep 10, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Sep 10, 2024

🎉 PR Next publish successful!

3.3.4-next-1725949351.0

erha19
erha19 previously approved these changes Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants