fix: platform detect logic #4021
Conversation
|
This PR was not deployed automatically as @erha19 does not have access to the Railway project. In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page. |
Walkthrough本次更改修改了操作系统和环境检测的逻辑。原有代码通过检查 Changes
Sequence Diagram(s)sequenceDiagram
participant A as Environment Check
participant B as Node.js
participant C as Web
A->>B: Check if nodeProcess is an object
alt Node.js Environment
B->>A: Set platform flags for Node.js
else Web Environment
A->>C: Check if navigator is an object
alt Valid Navigator
C->>A: Use userAgent to determine OS
A->>A: Set platform flags for Web
end
end
Tip OpenAI O1 model for chat
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
node 20 之后也有 navigator 了，你要判断一下 userAgent 是不是等于 Node.js 吧，不然是有问题的，会判断成浏览器层（浏览器为 windows, 背后实际为 linux）
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4021 +/- ##
=======================================
Coverage 54.46% 54.47%
=======================================
Files 1583 1583
Lines 96838 96840 +2
Branches 19831 19824 -7
=======================================
+ Hits 52744 52752 +8
+ Misses 36626 36617 -9
- Partials 7468 7471 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Types
Background or solution
fix 10c5d83#r146659795
navigator 属于运行时环境，程序执行过程中如果存在应该优先判断
对于前后端环境需要严格对齐的逻辑，应该使用
applicationService.backendOS和applicationService.frontendOS去做判断Changelog
fix platform detect logic
Summary by CodeRabbit
navigator.userAgent字符串，准确识别操作系统类型，提升了平台识别的清晰度。