Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest): [RO-26531] Migrated test runner to Jest #76

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

otrreeves
Copy link
Contributor

Ticket

https://opentable.atlassian.net/browse/RO-26531

Summary

This PR will update the test runner from Mocha to Jest

@otrreeves otrreeves requested a review from acolchado April 2, 2024 22:36
Copy link
Collaborator

@acolchado acolchado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but tests are failing in the GH env and the teamcity reporter is not needed.

jest.config.js Outdated
rootDir: '.',
testEnvironment: 'node',
testMatch: ['**/*.spec.js'],
testResultsProcessor: 'jest-teamcity-reporter',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed since it runs in Github actions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@otrreeves otrreeves requested a review from acolchado April 2, 2024 22:52
Copy link
Collaborator

@acolchado acolchado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@otrreeves otrreeves merged commit 3d957a4 into main Apr 2, 2024
3 checks passed
@otrreeves otrreeves deleted the chore/ro-26531-spur-web-migrate-to-jest branch April 2, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants