Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme, contribution guidelines and code of conduct #247

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Conversation

javfg
Copy link
Contributor

@javfg javfg commented Nov 25, 2020

Related issue: opentargets/issues#1054.

@javfg javfg force-pushed the jf-docs branch 4 times, most recently from 9ca745f to bcd1217 Compare November 26, 2020 09:07
Copy link
Contributor

@LucaFumis LucaFumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @javfg - looks great!

// to keep them separate from the template/expected ones below
Description.js
index.js
Section.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Body.js?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is this pull request not up to date with opentargets/issues#1131 (comment)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that I have to remove that part of the section.

@javfg javfg force-pushed the jf-docs branch 2 times, most recently from 12906fd to 7f91ab7 Compare November 30, 2020 13:40
@mirandaio mirandaio merged commit 6729ac6 into alpha Dec 14, 2020
@mirandaio mirandaio deleted the jf-docs branch January 19, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants