test(coloc): add coloc semantic test #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyg123
approved these changes
Mar 13, 2024
xyg123
added a commit
that referenced
this pull request
Mar 21, 2024
* fix: pytest for coloc unit tests * fix: removed unused coloc tests * test(coloc): add coloc semantic test (#538) * test(coloc): define fixtures and parametrise coloc tests * test(coloc): compare dfs with assert_frame_equal * fix: remove unused threshold variable --------- Co-authored-by: Irene López <45119610+ireneisdoomed@users.noreply.github.com> Co-authored-by: David Ochoa <ochoa@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is practically the implementation of the same semantic test but benefitting from pytest parametrising function to define the same testing logic for both scenarios.
Writing data inside the decorator is a pain (mainly getting the parenthesis right), but once it is sorted, it is much more legible than defining fixtures for semantic tests inside
conftest.I also switched the way to compare results to Pandas assert_frame_equal which is useful in cases where the floating point might vary.
Have a look at it and let me know your thoughts @xyg123