-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(l2g): streamline feature generation #544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-fm-improvements
…-fm-improvements
This was referenced Mar 15, 2024
Optimise feature matrix management to accelerate L2G Training and Prediction
opentargets/issues#3252
Closed
DSuveges
reviewed
Mar 18, 2024
DSuveges
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it looks absolutely reasonable.
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
The increase of V2G relationships (#543) caused L2G to crash.
The partitioning strategy was not optimised to extract that many feature annotations, which meant that executors had to deal with big chunks of data and would eventually die.
This job is heavy in the number of aggregation tasks it has to do, so having the data properly partitioned is important.
🛠 What does this PR implement
credible_set_w_variant_consequences
, I am selecting the data to be shuffled in the join.🙈 Missing
In an upcoming PR I'll address the biggest gain i've identified:
_get_max_coloc_per_credible_set
, we run this function twice:🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?