chore(l2g): log annotated gold standards in w&b #546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
This is the entry API to train the L2G model:
Everything except the input
gold_standard_data
are just set parameters.If we wanted to speed up experimenting as I suggest in opentargets/issues#3253, we would just need to store
gold_standard_data
.We can use W&B for that. We currently upload to W&B the train set of the annotated gold standards. I want to log the full matrix before splitting into train, test. Since we use a seed to split the data, this still makes sure we can reproduce the pipeline.
I like this idea because it binds the input data to the output model.
🛠 What does this PR implement
Changes in
LocusToGeneModel.evaluate
to accomplish the suggestion above.🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?