Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FM step with carma and sumstat imputation #568

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Conversation

addramir
Copy link
Contributor

@addramir addramir commented Apr 5, 2024

✨ Context

Continuation of the series of PR dedicated for fine-mapping wrappers.

🛠 What does this PR implement

This PR adds two functions for the fine-mapping step that has options for CARMA and sumstat imputation.

🙈 Missing

Need to add documentation in the future.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added size-M and removed size-S labels Apr 8, 2024
@addramir addramir marked this pull request as ready for review April 8, 2024 10:28
@addramir addramir merged commit 86600b0 into dev Apr 9, 2024
4 checks passed
@addramir addramir deleted the yt_finemapper_v4 branch April 9, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants