Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(susie_finemapper): correct syntax for saving the logs df #625

Merged
merged 3 commits into from
May 29, 2024
Merged

fix(susie_finemapper): correct syntax for saving the logs df #625

merged 3 commits into from
May 29, 2024

Conversation

tskir
Copy link
Contributor

@tskir tskir commented May 29, 2024 •
edited
Loading

✨ Context

The new version of finemapping, when ran with logging=True, outputs some statistics into a dataframe. However, there's a syntax bug preventing the pipeline from completing.

🛠 What does this PR implement

This PR fixes the syntax for outputting the logging dataframe.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@tskir tskir self-assigned this May 29, 2024
@github-actions github-actions bot added bug Something isn't working Step size-XS labels May 29, 2024
@addramir addramir merged commit 8ae94ea into dev May 29, 2024
4 checks passed
@addramir addramir deleted the tskir-susie-logs-fix branch May 29, 2024 12:50
project-defiant pushed a commit that referenced this pull request Jun 14, 2024
@tskir @addramir @project-defiant
fix(susie_finemapper): correct syntax for saving the logs df (#625)
5ccfd76 
* fix(susie_finemapper): correct syntax for saving the logs df

* fix(susie_finemapper): use parquet instead of csv

---------

Co-authored-by: Yakov <yt4@sanger.ac.uk>
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
Revert "fix(susie_finemapper): correct syntax for saving the logs df (#…
a3200f0 
…625)"

This reverts commit 5ccfd76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addramir addramir addramir approved these changes

@Daniel-Considine Daniel-Considine Awaiting requested review from Daniel-Considine

Assignees

@tskir tskir

Labels
bug Something isn't working size-XS Step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tskir @addramir