Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): 24.06 data release fixes #639

Merged
merged 5 commits into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/datasets/ot_gcp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ gwas_catalog_study_locus_folder: ${datasets.gwas_catalog_dataset}/study_locus_da
gwas_catalog_credible_set_folder: ${datasets.gwas_catalog_dataset}/credible_set_datasets

# GnomAD
gnomad_public_bucket: gs://gcp-public-data--gnomad/release
gnomad_public_bucket: gs://gcp-public-data--gnomad/release/
# LD generation
# Templates require placeholders {POP} to expand template to match multiple populationwise paths
ld_matrix_template: ${datasets.gnomad_public_bucket}/2.1.1/ld/gnomad.genomes.r2.1.1.{POP}.common.adj.ld.bm
Expand Down
2 changes: 1 addition & 1 deletion config/step/ot_ld_based_clumping.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
defaults:
- ld_based_clumping

ld_index_path: ${datasets.ld_index}
ld_index_path: ${datasets.ld_index}/2.1.1
project-defiant marked this conversation as resolved.
Show resolved Hide resolved
study_locus_input_path: ???
study_index_path: ???
clumped_study_locus_output_path: ???
2 changes: 1 addition & 1 deletion config/step/ot_ld_index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defaults:
ld_index_out: ${datasets.ld_index}
ld_matrix_template: ${datasets.ld_matrix_template}
ld_index_raw_template: ${datasets.ld_index_raw_template}
grch37_to_grch38_chain_path: ${datasets.chain_37_38.}
grch37_to_grch38_chain_path: ${datasets.chain_37_38}
liftover_ht_path: ${datasets.liftover_ht_path}
ld_populations:
- afr # African-American
Expand Down
3 changes: 3 additions & 0 deletions src/gentropy/ld_index.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def __init__(
ld_index_raw_template: str = LDIndexConfig().ld_index_raw_template,
ld_populations: list[LD_Population | str] = LDIndexConfig().ld_populations,
liftover_ht_path: str = LDIndexConfig().liftover_ht_path,
grch37_to_grch38_chain_path: str = LDIndexConfig().grch37_to_grch38_chain_path,
use_version_from_input: bool = LDIndexConfig().use_version_from_input,
) -> None:
"""Run step.
Expand All @@ -41,6 +42,7 @@ def __init__(
ld_index_raw_template (str): Input path to the raw gnomAD LD indices file with placeholder for population string
ld_populations (list[LD_Population | str]): Population names derived from the ld file paths
liftover_ht_path (str): Path to the liftover ht file
grch37_to_grch38_chain_path (str): Path to the chain file used to lift over the coordinates.
use_version_from_input (bool): Append version derived from input ld_matrix_template to the output ld_index_out. Defaults to False.

In case use_version_from_input is set to True,
Expand All @@ -57,6 +59,7 @@ def __init__(
GnomADLDMatrix(
ld_matrix_template=ld_matrix_template,
ld_index_raw_template=ld_index_raw_template,
grch37_to_grch38_chain_path=grch37_to_grch38_chain_path,
project-defiant marked this conversation as resolved.
Show resolved Hide resolved
ld_populations=ld_populations,
liftover_ht_path=liftover_ht_path,
)
Expand Down