Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SusieFineMapperStep): add new function with boundaries #645

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

addramir
Copy link
Contributor

@addramir addramir commented Jun 17, 2024

✨ Context

This PR adds new fine-mapper function that takes locus boundaries as input.

πŸ›  What does this PR implement

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@addramir addramir marked this pull request as ready for review June 17, 2024 13:23
@addramir addramir merged commit 79a6cb5 into dev Jun 17, 2024
4 checks passed
@addramir addramir deleted the yt_fm_boundaries branch June 17, 2024 13:33
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
* feat(SusieFineMapperStep): add new fucntion that takes boundaries as input

* fix: typo in function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants