-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ld_annotator): optional r2 threshold #648
Conversation
As I commented to @ireneisdoomed, there is an issue here, because This space is a bit messy at the moment. There is another related situation with the credible sets from finemapping that are at the moment lacking the LD annotation (between lead and tag). If we keep relying on the LDIndex for all these, we are applying dataset that was pre-filtered for the only purpose of the PICS road |
Your comment is correct, @d0choa. By default, we are already filtering by 0.5, and updated the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me. We are going to use the LD annotation and LD clumping for filtering duplicated credible sets after fine-mapping. As sugested by UKBB-PPP, the used threshold of R2>=0.8, stricter than 0.5.
It shouldn't alter the PICS route.
* feat(ld_annotator): apply r2 threshold * feat(ld_annotator): apply r2 threshold * chore(ldannotator): change threshold to 0.5
✨ Context
We want to be able to apply a threshold in the step of annotating the LD set of a StudyLocus dataset.
🛠 What does this PR implement
StudyLocus.filter_ld_set
, that enables to apply a filter on each r2 (after weighting by population)LDAnnotator.ld_annotate
🙈 Missing
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?