Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove python-semantic-release as project dependency #650

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

d0choa
Copy link
Collaborator

@d0choa d0choa commented Jun 18, 2024

✨ Context

We use python-semantic-release for releasing the python package as part of our CI/CD. However, there is no reason why this package is a project dependency. As suggested by @project-defiant we could just remove it from the poetry TOML.

🛠 What does this PR implement

Updates poetry TOML and poetry lock to remove python-semantic-release as a project dependency.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@d0choa
Copy link
Collaborator Author

d0choa commented Jun 18, 2024

closes #643

@d0choa d0choa marked this pull request as ready for review June 18, 2024 11:06
@d0choa d0choa merged commit ca377ce into dev Jun 18, 2024
4 checks passed
@d0choa d0choa deleted the do_semantic_release branch June 18, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants