feat: implement UKB PPP (EUR) ingestion & harmonisation #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
project-defiant
requested changes
Jun 21, 2024
Co-authored-by: Szymon Szyszkowski <69353402+project-defiant@users.noreply.github.com>
tskir
force-pushed
the
tskir-3234-ukb-ppp-eur
branch
from
f34d4ba
to
3864c24
Compare
project-defiant
approved these changes
Jun 25, 2024
project-defiant
added a commit
that referenced
this pull request
Jul 12, 2024
* feat: implement UKB PPP (EUR) ingestion & harmonisation * fix: correct module name for docs * fix: definitely correct module name for docs * test: update output of neglog_pvalue_to_mantissa_and_exponent * fix: test syntax with <BLANKLINE> * Update src/gentropy/datasource/ukb_ppp_eur/summary_stats.py Co-authored-by: Szymon Szyszkowski <69353402+project-defiant@users.noreply.github.com> * fix: code review updates for docs and version * fix: syntax for concat_ws * style: list harmonisation steps in the docstring * style: rename freq to MAF * style: use concat_ws * style: use two distinct parameters for study index and summary stats output paths --------- Co-authored-by: Szymon Szyszkowski <69353402+project-defiant@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
Closes opentargets/issues#3234.
🛠 What does this PR implement
All components necessary for ingesting and harmonising the UKB PPP (EUR) datasource.
🙈 Missing
N/A.
🚦 Before submitting
devbranch?make test)?poetry run pre-commit run --all-files)?