Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in cs_lbf_thr parameter name #667

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: typo in cs_lbf_thr parameter name #667

merged 2 commits into from
Jul 3, 2024

Conversation

tskir
Copy link
Contributor

@tskir tskir commented Jul 3, 2024 •
edited
Loading

✨ Context

There is a typo in the cs_lbf_thr parameter name in the FinemapperConfig class. This causes problems when trying to define while triggering a Google Batch job.

🛠 What does this PR implement

Fix the typo.

🙈 Missing

N/A.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working Step size-XS labels Jul 3, 2024
@tskir tskir self-assigned this Jul 3, 2024
@tskir tskir merged commit f0a2902 into dev Jul 3, 2024
4 checks passed
@tskir tskir deleted the tskir-fix-parameter-name branch July 3, 2024 10:56
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
@tskir @addramir
fix: typo in cs_lbf_thr parameter name (#667)
b0adb68 
* fix: typo in cs_lbf_thr parameter name

* fix: removing two parameters

---------

Co-authored-by: Yakov Tsepilov <yt4@sanger.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addramir addramir addramir approved these changes

@Daniel-Considine Daniel-Considine Awaiting requested review from Daniel-Considine

Assignees

@tskir tskir

Labels
bug Something isn't working size-XS Step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tskir @addramir