Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: credible set quality control step #681

Merged
merged 6 commits into from
Jul 9, 2024
Merged

feat: credible set quality control step #681

merged 6 commits into from
Jul 9, 2024

Conversation

Daniel-Considine
Copy link
Contributor

✨ Context

🛠 What does this PR implement

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added size-M and removed size-S labels Jul 9, 2024
@Daniel-Considine Daniel-Considine merged commit 27c9b6b into dev Jul 9, 2024
4 checks passed
@Daniel-Considine Daniel-Considine deleted the dc_cs_qc branch July 9, 2024 15:28
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
@Daniel-Considine
feat: credible set quality control step (#681)
e96b0dc 
* feat: credible set quality control step

* feat: credible_set_qc.py step

* chore: updating genotropy/config.py to include CredibleSetQCConfig()

* chore: updated LocusBreakerClumpingConfig(StepConfig)

* fix: changing default configs in code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addramir addramir addramir approved these changes

Assignees
No one assigned
Labels
Dataset Feature Method size-M Step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daniel-Considine @addramir