Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(finemapping): reconcile changes in the finemapping step with config #682

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix(finemapping): reconcile changes in the finemapping step with config #682

merged 1 commit into from
Jul 9, 2024

Conversation

tskir
Copy link
Contributor

@tskir tskir commented Jul 9, 2024 •
edited
Loading

✨ Context

Two values were recently removed from the step in #679.

🛠 What does this PR implement

This brings config in alignment with these changes.

🙈 Missing

N/A

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@tskir
fix: reconcile changes in the finemapping step with config
93fad9c 
Two values were recently removed from the step. This brings config in alignment with these changes.
@tskir tskir requested a review from DSuveges July 9, 2024 14:53
@github-actions github-actions bot added bug Something isn't working Step size-XS labels Jul 9, 2024
@tskir tskir changed the title fix: reconcile changes in the finemapping step with config fix(finemapping): reconcile changes in the finemapping step with config Jul 9, 2024
@addramir addramir merged commit 8986e86 into dev Jul 9, 2024
4 checks passed
@addramir addramir deleted the tskir-fix-finemapping-step branch July 9, 2024 14:58
project-defiant pushed a commit that referenced this pull request Jul 12, 2024
@tskir
fix: reconcile changes in the finemapping step with config (#682)
bbeb98e 
Two values were recently removed from the step. This brings config in alignment with these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addramir addramir addramir approved these changes

@DSuveges DSuveges Awaiting requested review from DSuveges

@Daniel-Considine Daniel-Considine Awaiting requested review from Daniel-Considine

Assignees
No one assigned
Labels
bug Something isn't working size-XS Step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tskir @addramir