-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flag MHC credible sets based on lead #767
Conversation
…/opentargets/gentropy into do_fix_credible_set_filter_issue
@DSuveges and @Daniel-Considine, this touches on code that you worked on in the past, so please feel free to raise any objections. I'm assigning the review to Szymon and Yakov. (I didn't want to assign everyone 😅) |
Looks all good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a comment in the src/gentropy/study_locus_validation.py
file indicating a filtering for MHC, however I cannot find the logic to do so. Is it intentional? I suspect the comment should go, and a exclusion flag needs to be added to the orchestration.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the flagging comment is duplicated, but this is no way block the PR.
that's why I shouldn't do commits from the web. Fixed now |
This PR closes opentargets/issues#3469.
It implements:
It's pending:
IN_MHC
to orchestration config