Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove n_eff check from qc_step #785

Merged
merged 4 commits into from
Sep 24, 2024
Merged

fix: remove n_eff check from qc_step #785

merged 4 commits into from
Sep 24, 2024

Conversation

addramir
Copy link
Contributor

✨ Context

Removing the most uncredible QC function from QC step. Still there and unite tested but not used in step anymore.

πŸ›  What does this PR implement

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working size-S Method Step labels Sep 24, 2024
@addramir addramir marked this pull request as ready for review September 24, 2024 15:36
@addramir addramir merged commit 2010fb6 into dev Sep 24, 2024
5 checks passed
@addramir addramir deleted the yt_remove_neff_check branch September 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Method size-S Step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants