Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): adding credible set confidence annotation at validation time #801

Merged
merged 13 commits into from
Oct 1, 2024

Conversation

DSuveges
Copy link
Contributor

@DSuveges DSuveges commented Oct 1, 2024

✨ Context

This PR introduces credible set confidence classes, which is assigned to credible sets upon validation. The basis of the assignment is the fine-mapping method and the presence of certain quality control flags. This is a preliminary implementation, we can decide to make the classes more granular.

@DSuveges DSuveges marked this pull request as ready for review October 1, 2024 11:15
@DSuveges DSuveges requested a review from d0choa October 1, 2024 11:15
Copy link
Collaborator

@d0choa d0choa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. If you have time to add at least a return_type unit test for assign_confidence it could be good to make sure that the function at least runs

@github-actions github-actions bot added size-M and removed size-S labels Oct 1, 2024
@DSuveges DSuveges merged commit 1c396d2 into dev Oct 1, 2024
5 checks passed
@DSuveges DSuveges deleted the ds_3556_stars branch October 1, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introducing a star system for credible sets
2 participants