Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop redundant parameter from sumstat qc step #802

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

project-defiant
Copy link
Contributor

✨ Context

Currently study_id is a required parameter for running the summary_statistics_qc step. This is not ideal, as when running in bulk, we can not specify which study_id should be used to create the qc output path.

🛠 What does this PR implement

  • Removal of study_id parameter from the summary_statistics_qc step
  • Removal of static /qc_results_ that is appended in the step output

The path to QC should be fully configurable, without it's part being hardcoded.

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense. We no longer need a study identifier, the output path is directly given instead of being constructed with studyId.

@DSuveges DSuveges merged commit a5588ae into dev Oct 1, 2024
5 checks passed
@DSuveges DSuveges deleted the sumstat-qc-fix-params branch October 1, 2024 11:09
project-defiant added a commit that referenced this pull request Oct 1, 2024
Co-authored-by: Szymon Szyszkowski <ss60@mib117351s.internal.sanger.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants