feat: fix biosample study validation #810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
Fixes a bug in the study validation where checking studies for biosample index would drop all GWAS studies. Also implements additional testing to catch this scenario in the future.
🛠 What does this PR implement
Changed the logic of the biosample_index study validation slightly to match the gene_index study validation a bit closer. Also modified the TestGeneValidation suite to be more abstract and inclusive i.e. be applicable to any study validation that is only for QTLs.
🙈 Missing
One function is duplicated instead of abstracted as the amount of code written was similar so I thought perhaps better to keep simple.
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?