Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove h4/h3 ratio #829

Merged
merged 11 commits into from
Oct 15, 2024
Merged

chore: remove h4/h3 ratio #829

merged 11 commits into from
Oct 15, 2024

Conversation

addramir
Copy link
Contributor

@addramir addramir commented Oct 10, 2024

✨ Context

!DON'T MERGE IT BEFORE THE RELEASE, IT CHANGES SCHEMA!

πŸ›  What does this PR implement

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@d0choa
Copy link
Collaborator

d0choa commented Oct 11, 2024

if you get this ready, we can include it in one of the next data iterations.
I know it's not critical, but the earlier we clean up things the better.

@addramir addramir marked this pull request as ready for review October 14, 2024 15:25
@addramir addramir requested a review from d0choa October 14, 2024 15:37
@d0choa d0choa merged commit 172cedf into dev Oct 15, 2024
5 checks passed
@d0choa d0choa deleted the yt_remove_h3h4 branch October 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants