fix(l2g): remove custom session params + other fixes #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
@d0choa observed a Java memory issue when running the L2G training
(more here)
The L2G training step had a custom session that provided more memory to the cluster. This was inherited from the previous L2G version where this step included the feature matrix generation and the training was happening in Spark.
Because L2G is now a much lighter step, the default spark configuration should be enough.
🛠 What does this PR implement
LocusToGeneStepConfig
that extended the spark configuration. I am still defining the default session inside the step configuration, because otherwise I'd need to provide it if I want to access any step attribuites. This is because the child step inherits from the Step class, which requires a session. For example:🙈 Missing
Didn't run the whole L2G step (run into an error that #837 fixes), but the crash wasn't due to Java.
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?