Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l2g): normalise distance features #878

Merged
merged 4 commits into from
Oct 25, 2024
Merged

feat(l2g): normalise distance features #878

merged 4 commits into from
Oct 25, 2024

Conversation

ireneisdoomed
Copy link
Contributor

@ireneisdoomed ireneisdoomed commented Oct 25, 2024

✨ Context

This PR closes opentargets/issues#3587

πŸ›  What does this PR implement

  • We divide the distance features by log10(500_000+1) to keep them in a range between 0 and 1.

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@ireneisdoomed ireneisdoomed merged commit 3e61996 into dev Oct 25, 2024
5 checks passed
@ireneisdoomed ireneisdoomed deleted the il-3587 branch October 25, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalise distance features
2 participants