feat(susie_finemapper): ensure proper output paths #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR resolves 2 issues with the output paths from finemapping of ukb_ppp_eur datasource.
Finemapping results from ukb_ppp_eur contained log file and finemapped loci parquet in the same directory, which could cause trouble when reading the loci files.
The output path of the finemapping results contained the
studyLocusId=XXX
segment that was inferred by spark, as if the dataset was partitionned bystudyLocusId
column but in reality it was not partitionned at all.see more info in opentargets/gentropy#859
This PR attempts to:
studyLocusId=
is being removed from the prefix path.log_path
parameter that will be used as a base path to the finemapping logs