[Platform]: Add DisplayVariantId component #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
DisplayVariantIdcomponent and use it where show variant id - currently in variant page header and section descriptions.The PR includes small changes to
packages/ui/src/components/Section/SectionItem.jsx:renderDescriptionfunction - and show a skeleton if not.<div>rather than<p>for the description subheader to avoid DOM nesting warnings from MUI.Issue: 3390
Preview: https://deploy-preview-441--ot-platform.netlify.app/variant/OTVAR_1_109607656_cc1bda57abafe82ac6cb5ec620a02a19
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checked on dev.
Checklist: