Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: table column and chart view #479

Merged
merged 47 commits into from
Oct 29, 2024
Merged

[Platform]: table column and chart view #479

merged 47 commits into from
Oct 29, 2024

Conversation

chinmehta
Copy link
Contributor

@chinmehta chinmehta commented Sep 18, 2024

[Platform]: table column and chart view

Description

column visibility and table column and chart view switch

Issue: https://deploy-preview-479--ot-platform.netlify.app/
Deploy preview: (link)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

@carcruz
Copy link
Contributor

carcruz commented Sep 24, 2024

@chinmehta Can you please:

  • remove text from the BTNs
  • tooltip for help
  • default view prop
  • There's a bug if you click first element while is active

@chinmehta chinmehta marked this pull request as ready for review October 15, 2024 13:24
@chinmehta chinmehta requested a review from carcruz October 15, 2024 13:28
@carcruz carcruz merged commit a1d2c2d into main Oct 29, 2024
11 checks passed
@carcruz carcruz deleted the cm-table-column branch October 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants