Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: Add plot components #522

Merged
merged 17 commits into from
Nov 13, 2024
Merged

[Platform]: Add plot components #522

merged 17 commits into from
Nov 13, 2024

Conversation

gjmcn
Copy link
Contributor

@gjmcn gjmcn commented Nov 7, 2024

Description

Adds:

  • plot components to UI
  • Manhattan plot to study page

Note: this PR is a draft to check the new plot components and gather feedback for the final version of the plot.

To do:

  • responsive to width changes (plot is currently fixed width)
  • tooltip
  • skeleton when loading?
  • polish colors and text
  • ensure robust to missing data
  • ignore variants from chromosome 23 and 24

Issue: #3502
Deploy preview: https://deploy-preview-522--ot-platform.netlify.app/study/GCST90078245

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checked on dev

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

@carcruz carcruz merged commit 29d57fc into main Nov 13, 2024
11 checks passed
@carcruz carcruz deleted the gm-plot-components branch November 13, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants