3379 cred set #196
Merged
3379 cred set #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhayhurst
reviewed
Jul 24, 2024
app/models/ElasticRetriever.scala
Outdated
There was a problem hiding this comment.
Should this be an Any type?
There was a problem hiding this comment.
Yes, the Id for the credible set is of type Long. The underlying object is also of type Iterable[Any] (def idsQuery(ids: Iterable[Any]): IdQuery = IdQuery(ids.toSeq)).
javfg
approved these changes
Aug 2, 2024
jdhayhurst
pushed a commit
that referenced
this pull request
Sep 19, 2024
* credible set endpoint and entity * format files * add fectcher to clean cache and resolvers * add new fields * Filter documents * update id type * update to JsValue * format file * remove commeted code * undo Any type
jdhayhurst
pushed a commit
that referenced
this pull request
Dec 11, 2024
* credible set endpoint and entity * format files * add fectcher to clean cache and resolvers * add new fields * Filter documents * update id type * update to JsValue * format file * remove commeted code * undo Any type
jdhayhurst
pushed a commit
that referenced
this pull request
Dec 11, 2024
* credible set endpoint and entity * format files * add fectcher to clean cache and resolvers * add new fields * Filter documents * update id type * update to JsValue * format file * remove commeted code * undo Any type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.