Fixes issue with --neuron.no_set_weights #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabella618033
approved these changes
Dec 1, 2022
camfairchild
deleted the
fix/1019-serving-with-neuronno_set_weights-calls-metagraphsync-every-minute-or-two
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1019
Currently, the metagraph sync is executed every time the if-statement on line 457 evaluates as true.
if current_block - last_set_block > blocks_per_set_weights:However,
last_set_blockis never updated whenconfig.neuron.no_set_weightsis true.This PR moves
last_set_block = current_blockoutside the check forno_set_weights, fixing the bug