add default 1024 max stake limit for querying UIDs with vpermit. #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ifrit98
commented
Jun 2, 2023
ifrit98
commented
- Small change, make sure that UIDs with a vpermit but under stake limit (1024 by default) are still queried.
Eugene-hu
approved these changes
Jun 2, 2023
adriansmares
reviewed
Jun 2, 2023
| @@ -328,12 +329,14 @@ def forward( | |||
| # Set `topk` to the number of items in `self.metagraph.n` if `topk` is not provided or is -1. | |||
| # Find the available `uids` that are currently serving. | |||
| # If `topk` is larger than the number of available `uids`, set `topk` to the number of available `uids`. | |||
| available_uids = torch.tensor( [ uid for uid, ax in enumerate( self.metagraph.axons ) if (ax.is_serving) and (not self.metagraph.validator_permit[uid]) ], dtype = torch.int64 ).to( self.device ) | |||
| # Check if we have vpermit and if we do, ensure query only UIDs with less than vpermit_tao_limit. | |||
| candidate_uids = [uid for uid, ax in enumerate(self.metagraph.axons) if ax.is_serving and ((self.metagraph.validator_permit[uid] and self.metagraph.S[uid] < self.config.neuron.vpermit_tao_limit) or not self.metagraph.validator_permit[uid])] | |||
There was a problem hiding this comment.
This condition should also be updated in check_weights.
Can also be simplified to not self.metagraph.validator_permit[uid] or self.metagraph.S[uid] < self.config.neuron.vpermit_tao_limit.
There was a problem hiding this comment.
Assume it would be as simple as changing the 2nd if condition in check_weights to:
for uid, hotkey in enumerate( self.hotkeys ):
if hotkey != self.metagraph.hotkeys[ uid ]:
self.moving_averaged_scores[ uid ] = 0 #hotkey has been replaced
if self.metagraph.validator_permit[ uid ] and self.metagraph.S[ uid ] < self.config.neuron.vpermit_tao_limit:
self.moving_averaged_scores[ uid ] = 0 # hotkey has validation rights and is below the tao limitLet me know if this is an incorrect assumption.
unconst
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.