feat(wallets.py): add wallet history command

[saqib-codes-11]

Description :-

This PR adds the following new command to fetch all the transfers associated with the provided "Wallet Name".

Command - btcli wallet history --wallet.name xyz

Screenshot -

[ifrit98]

Thanks for the contribution! Looks good overall, left you some comments with a request for updating the while loop.

[ifrit98]

Generally weary of unbounded while True statements in python. This technically should terminate on the desired condition, but may want to explicitly put the exit condition in this line and/or specify some other conditions for exiting. For example, if there is significant txn volume, we may want to limit the output to n txns.

For example, adding a max_txn_history that we exit upon reaching:

max_txn_history = 1000 # this should be set in the config.
page_info = {"page_info": {"hasNextPage": True}} # for initial loop entry, will be filled by `transfer_data`
while len(transfers) < max_txn_history and page_info.get("hasNextPage") == True:
    ...

What do you think?

[saqib-codes-11]

Yeah, I think it will be a better approach. Will be fixing this in the next commit.

[alex0500]

You not need while. Change 10 to 1000 or more

[saqib-codes-11]

@alex0500 removed while and set max_txn to 1000.

[ifrit98]

Also, in the future, would you mind branching off from staging? This is the preferred workflow outlined in the contrib docs for development.

Thanks!

[ifrit98]

Any new feature should include proper tests for them, including new btcli functions. Make sure to add this as well in tests/integration_tests/test_cli.py and/or tests/integration_tests/test_cli_no_network.py where appropriate.

Thanks!

[saqib-codes-11]

Any new feature should include proper tests for them, including new btcli functions. Make sure to add this as well in tests/integration_tests/test_cli.py and/or tests/integration_tests/test_cli_no_network.py where appropriate.

Thanks!

Added

[ifrit98]

Thanks for the updated tests and testing out the query. Looks good!

Two small nits for you and we should be good to merge:
(1) Don't unlock coldkey to get ss58_address
(2) Display values in tao instead of rao (and mention this in the column, e.g. Amount (tao)

Suggestion for a nice to have, but is not necessary IMO:
(3) May be nice to add a column for Time, translating the block number into datetimes. What do you think?

... |  Block No  | Time
... |   2044685  | Nov 1, 2023 12:21:00 
...

[ifrit98]

It is somewhat cumbersome to enter the password each time to simply get the coldkey address, which is not exactly private data.

Suggestion:

wallet_address = wallet.get_coldkeypub().ss58_address

[saqib-codes-11]

This is done.

[ifrit98]

The current amount displayed is in rao, and displaying in tao may be more user-friendly. It's a simple divide by 1e9

Suggestion:

int(item["amount"]) / 1e9

May want to do some error handling if the value cannot be converted to an int.

[saqib-codes-11]

This is also done. Tested it for the below values,
2
2.9
"2"
"2.989767"

Any invalid integer will throw an error, in that case, I am using it as it as. Any other suggestions on the same?

[alex0500]

Where is time of transfers?

[saqib-codes-11]

Thanks for the updated tests and testing out the query. Looks good!

Two small nits for you and we should be good to merge: (1) Don't unlock coldkey to get ss58_address (2) Display values in tao instead of rao (and mention this in the column, e.g. Amount (tao)

Suggestion for a nice to have, but is not necessary IMO: (3) May be nice to add a column for Time, translating the block number into datetimes. What do you think?

... |  Block No  | Time
... |   2044685  | Nov 1, 2023 12:21:00 
...

I did complete the first two changes but I was not able to get the correct time using the block number,

I tried the below formula to calculate it but was getting a 1-day difference.

from datetime import datetime, timedelta
time_for_target_block = timedelta(seconds=(target_block_number - 1) * substrate_block_time)
target_block_time = first_block_time + time_for_target_block

[ifrit98]

LGTM. I'll take it from here