-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Synapse passing type check #1725
Feature: Synapse passing type check #1725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code you've written to check for the presence of None in attributes is clear and functionally sound. This explicit handling demonstrates good defensive programming practices. However, considering maintainability and readability, you might find it beneficial to explore more concise ways to achieve the same functionality. Utilizing Python's ability to handle such checks in a more streamlined manner could reduce verbosity and improve code clarity.
We need to follow PEP 8 styleguide on all code moving forward. The essence of following PEP 8 is not just about adhering to rules for the sake of rules but about writing code that is clean, easy to read, and easy for others to understand and maintain. This will produce high-quality, professional code that stands out in the Python community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bittensor/synapse.py
updated to pass type checkingsynapse
block so that mypy runs type checking againstbittensor/synapse.py