[BIT-540] Choose responsive UIDs for setting weights in validator + validator save/load #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer current epoch's responsive UIDs, randomly sample min_allowed_weights number of UIDs to set weights to. Discard max_allowed_ratio in favor of filtering non-zero weights, expecting consensus-levels (number of validators setting weights for UID) to be equal on average for responsive nodes. This means max_allowed_ratio is no longer strictly required for boosting consensus. If there are less than min_allowed_weights non-zero weights, then set_weights should fail.
Return a k length list of unique elements chosen from the population sequence or set. Used for random sampling without replacement (so no uid duplicates expected).
Uses save and load format of core_server.
opentaco
changed the title
isabella618033
approved these changes
Aug 11, 2022
| neuron_weights = neuron_weights[neuron_weights > 0] # filter to non-zero weights | ||
|
|
||
| # === Slice min_allowed_weights UIDs === | ||
| sample_uids = preferred_uids[:min_allowed_weights] # slice to min_allowed_weights |
There was a problem hiding this comment.
actually i have always been confused, cause min_allowed_weight is just the minimum network requirement,
so shouldnt we set it to max(min_allowed_weight, len(responsive_uids)) ?
There was a problem hiding this comment.
Previously and currently validators always fixed the number of weights set to min_allowed_weight, likely because the demands on subtensor are more predictable then and because validators operate more similarly the consensus is improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIT-540 Choose responsive UIDs for setting weights in validator
Prefer current epoch's responsive UIDs, randomly sample min_allowed_weights number of UIDs to set weights to.
Discard max_allowed_ratio in favor of filtering non-zero weights, expecting consensus-levels (number of validators setting weights for UID) to be equal on average for responsive nodes. This means max_allowed_ratio is no longer strictly required for boosting consensus.
If there are less than min_allowed_weights non-zero weights, then set_weights should fail.
BIT-536 Validator save and load from filesystem