-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BIT-598] Validator debug response table #999
Merged
opentaco
merged 21 commits into
nobunaga
from
feature/BIT-598/validator-debug-response-table
Nov 20, 2022
Merged
[BIT-598] Validator debug response table #999
opentaco
merged 21 commits into
nobunaga
from
feature/BIT-598/validator-debug-response-table
Nov 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentaco
requested review from
Eugene-hu,
shibshib and
isabella618033
and removed request for
Eugene-hu and
shibshib
November 18, 2022 10:46
Eugene-hu
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIT-598 Validator debug response table
Adds an additional debug table to
core_validator... --logging.debug
that samples query tasks and server responses, formats it compactly, and displays the topk predicted phrases with probabilities.The intended use of this table is to monitor and confirm proper query handling by displaying actual response content. This can also help to detect response anomalies that can help identify various new code/system/network errors that may have been introduced.
Apart from a task selection the table also includes overall step statistics for responsive servers.
Rich MarkupError exceptions are infrequently caught and handled when special characters in the task representation corrupt added markup.