reset neuron data on dereg #755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreea-popescu-reef also changed the base against |
andreea-popescu-reef
force-pushed
the
fix-reg
branch
2 times, most recently
from
bdd5e14
to
5e425fb
Compare
| } | ||
|
|
||
| /// Resets the trust, emission, consensus, incentive, dividends of the neuron to default | ||
| pub fn clear_neuron(netuid: u16, neuron_uid: u16) { |
There was a problem hiding this comment.
Can we optimise this by reducing the number of storage / writes , and number of function calls ?
pub fn clear_neuron(netuid: u16, neuron_uid: u16) {
let neuron_index: usize = neuron_uid.into();
let default_value = 0;
for storage in &mut [
&mut Emission::<T>::get(netuid),
&mut Trust::<T>::get(netuid),
&mut Consensus::<T>::get(netuid),
&mut Incentive::<T>::get(netuid),
&mut Dividends::<T>::get(netuid),
] {
set_element_at(storage, neuron_index, default_value);
}
}There was a problem hiding this comment.
that does not quite work as the vectors have different int types
There was a problem hiding this comment.
it's the same number of calls to the set_element_at. is there much difference between get vs mutate calls? aren't they compiled to similar things?
There was a problem hiding this comment.
anyway made the change
andreea-popescu-reef
force-pushed
the
fix-reg
branch
from
5e425fb
to
5e45f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reviving: #522
Description
On neuron registration the trust, emission, consensus, incentive, dividends values as well as axon info associated with the assigned neuron_uid are inherited from the previous neuron. Thus for the first few blocks after registration these values will be wrong, then reset to zero and then get populated with the correct values for the newly registered neuron. This change resets these values on neuron registration.