Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localnet improvement #802

Open
wants to merge 24 commits into
base: devnet-ready
Choose a base branch
from
Open

Conversation

open-junius
Copy link
Contributor

@open-junius open-junius commented Sep 11, 2024

Description

The feature will improve the localnet configuration for testing.

tasks

  • REQ-LOCNET-001: Configure "pow-faucet" feature for registrations

  • Enable the "pow-faucet" feature for the Localnet configuration.

  • This feature should be used to manage registrations in the Localnet environment.

  • REQ-LOCNET-002: Set initial max registrations per block to 1000

  • Update the SubtensorInitialMaxRegistrationsPerBlock constant to 1000.

  • This should only apply when the "pow-faucet" feature is enabled.

  • REQ-LOCNET-003: Set initial target registrations per interval to 1000

  • Update the SubtensorInitialTargetRegistrationsPerInterval constant to 1000.

  • This should only apply when the "pow-faucet" feature is enabled.

  • REQ-LOCNET-004: Create subnet 1
    Not in subtensor side, we will use btcli to create.

  • REQ-LOCNET-005: Remove subnet 3

  • Subnet 3 should not be present in the Localnet configuration.

  • Any references or dependencies on subnet 3 should be removed from the Localnet codebase.

  • REQ-LOCNET-006: Create predefined accounts with specific roles
    Not in subtensor side, we will use btcli to create. And pre-defined accounts are the same as balances.

  • REQ-LOCNET-007: Set specific TAO balances for predefined accounts
    pre-defined accounts are the same as balances in local chain setting.

  • REQ-LOCNET-008: Implement account creation and balance setting on Localnet initialization

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius changed the title init solution localnet improvement Sep 11, 2024
@open-junius open-junius self-assigned this Sep 24, 2024
sam0x17
sam0x17 previously approved these changes Sep 24, 2024
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ran locally and was easy to configure

@open-junius open-junius requested a review from a team September 26, 2024 12:50

// --- Fill modality item.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues here with this condition. Should also avoid inputting Subnet 3 into the other storage values later in this function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants