Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix EVM <=> TAO balance transfer precision #984

Merged
merged 20 commits into from
Nov 15, 2024
Merged

fix EVM <=> TAO balance transfer precision #984

merged 20 commits into from
Nov 15, 2024

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Nov 15, 2024 •
edited
Loading

Previously, the EVM integration imposed a maximum transfer limit of 18.4 TAO to avoid precision loss when converting between EVM (18 decimals) and Substrate (9 decimals).

This update removes the transfer limit by truncating excess decimals from the least significant end during the conversion. As a result, large transfers are now allowed. Infinitesimally small amounts of WEI (less than the precision of TAO) are discarded during this process, and a log entry is generated whenever such precision loss occurs.

also includes some CI fixes:

  • cargo audit version locked for now to prevent regressions of the Cargo.lock parsing issue
  • don't need to install rustup because it is pre-installed with stable already installed

@sam0x17 sam0x17 added the bug Something isn't working label Nov 15, 2024
@sam0x17 sam0x17 self-assigned this Nov 15, 2024
@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Nov 15, 2024
@sam0x17 sam0x17 changed the base branch from main to devnet-ready November 15, 2024 17:21
@opentensor opentensor deleted a comment from github-actions bot Nov 15, 2024
@sam0x17 sam0x17 removed the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Nov 15, 2024
gztensor
gztensor previously approved these changes Nov 15, 2024
View reviewed changes
gztensor
gztensor previously approved these changes Nov 15, 2024
View reviewed changes
@gztensor gztensor linked an issue Nov 15, 2024 that may be closed by this pull request
Bug: Cannot transfer more than 18.4 TAO with EVM #981
Open
@sam0x17 sam0x17 merged commit 03527fa into devnet-ready Nov 15, 2024
13 checks passed
@sam0x17 sam0x17 mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gztensor gztensor gztensor approved these changes

@unconst unconst Awaiting requested review from unconst unconst is a code owner

Assignees

@sam0x17 sam0x17

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Cannot transfer more than 18.4 TAO with EVM
2 participants
@sam0x17 @gztensor