-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Thread 1.4 reference builds #79
Conversation
edcf598
to
48f87e5
Compare
@LuDuda FYI |
48f87e5
to
1ee19a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It seems the CI is failing due to low CMake version.
|
deb2319
to
f73102d
Compare
@suveshpratapa It seems bumping the version of ot-commissioner is not a trivial step. There may be more actions needed to fix the CI failure: https://github.com/openthread/ot-reference-release/actions/runs/10164731867/job/28110844136?pr=79. Can we bump it in another PR? |
@suveshpratapa The build problems of NCS are addressed here #82 |
The ot-commissioner's build failure should be fixed by openthread/ot-commissioner#291. |
I just merged the |
f73102d
to
04ee24d
Compare
04ee24d
to
287a50d
Compare
@suveshpratapa Since there are already some build failures and the PR includes multiple tasks (script change and bumping repos), could you consider dividing the PR into multiple ones? That should make it easier for debugging the build failures. Maybe you can create a PR for bumping the repos and another PR for script changes. |
d1a8ea2
to
ff80b63
Compare
@superwhd Modified this PR to only have the script changes and split the others into their own PRs
|
https://github.com/openthread/ot-reference-release/actions/runs/10216991615?pr=79 |
@suveshpratapa The NCS 1.4 build fails for you because the reference configs do not exist for 1.4 yet in both Zephyr and NCS. We are working curently on adding 1.4 for now You can leave 1.3.1 ad default in builds for 1.4. It should work ok for You. |
@suveshpratapa #85 should allow building thread 1.4 in NCS |
ff80b63
to
9ed5926
Compare
@maciejbaczmanski Can you check what could be happening? I rebased to include your merged changes and t's still failing to build NCS for 1.4. |
error can be seen here: https://github.com/openthread/ot-reference-release/actions/runs/10404358834
So it seems like a CI issue? |
I just submitted #87, hopefully it will help. |
@suveshpratapa , I just merged #87. Can you rebase this PR and see if it helps? |
9ed5926
to
d33c483
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The CI finally passed! 🎉
No description provided.