Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Thread 1.4 reference builds #79

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

suveshpratapa
Copy link
Member

@suveshpratapa suveshpratapa commented Jul 22, 2024

No description provided.

@canisLupus1313
Copy link
Contributor

@LuDuda FYI

script/make-firmware.bash Outdated Show resolved Hide resolved
script/make-firmware.bash Outdated Show resolved Hide resolved
script/make-firmware.bash Show resolved Hide resolved
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

It seems the CI is failing due to low CMake version.

@sunytt
Copy link
Contributor

sunytt commented Jul 29, 2024

.github/workflows/build.yml still builds 1.3.1, could you update it to 1.4?

@suveshpratapa suveshpratapa force-pushed the task/1.4-reference-updates branch 2 times, most recently from deb2319 to f73102d Compare July 30, 2024 14:55
@superwhd
Copy link
Contributor

@suveshpratapa It seems bumping the version of ot-commissioner is not a trivial step. There may be more actions needed to fix the CI failure: https://github.com/openthread/ot-reference-release/actions/runs/10164731867/job/28110844136?pr=79.

Can we bump it in another PR?

@canisLupus1313
Copy link
Contributor

@suveshpratapa The build problems of NCS are addressed here #82

@superwhd
Copy link
Contributor

superwhd commented Aug 1, 2024

The ot-commissioner's build failure should be fixed by openthread/ot-commissioner#291.

@jwhui
Copy link
Member

jwhui commented Aug 1, 2024

The ot-commissioner's build failure should be fixed by openthread/ot-commissioner#291.

I just merged the ot-commissioner PR.

@suveshpratapa
Copy link
Member Author

I just merged the ot-commissioner PR.

@jwhui Thank you, just incorporated into this PR. Now just need to wait for Nordic PR #82 to be merged.

@jwhui
Copy link
Member

jwhui commented Aug 1, 2024

@jwhui Thank you, just incorporated into this PR. Now just need to wait for Nordic PR #82 to be merged.

Merged the Nordic PR as well.

@superwhd
Copy link
Contributor

superwhd commented Aug 2, 2024

@suveshpratapa Since there are already some build failures and the PR includes multiple tasks (script change and bumping repos), could you consider dividing the PR into multiple ones? That should make it easier for debugging the build failures.

Maybe you can create a PR for bumping the repos and another PR for script changes.

@suveshpratapa suveshpratapa force-pushed the task/1.4-reference-updates branch 2 times, most recently from d1a8ea2 to ff80b63 Compare August 2, 2024 14:08
@suveshpratapa
Copy link
Member Author

suveshpratapa commented Aug 2, 2024

@suveshpratapa Since there are already some build failures and the PR includes multiple tasks (script change and bumping repos), could you consider dividing the PR into multiple ones? That should make it easier for debugging the build failures.

Maybe you can create a PR for bumping the repos and another PR for script changes.

@superwhd Modified this PR to only have the script changes and split the others into their own PRs

@superwhd
Copy link
Contributor

superwhd commented Aug 5, 2024

The hosted runner: GitHub Actions 403 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

https://github.com/openthread/ot-reference-release/actions/runs/10216991615?pr=79

@canisLupus1313
Copy link
Contributor

@suveshpratapa The NCS 1.4 build fails for you because the reference configs do not exist for 1.4 yet in both Zephyr and NCS. We are working curently on adding 1.4 for now You can leave 1.3.1 ad default in builds for 1.4. It should work ok for You.

@maciejbaczmanski maciejbaczmanski mentioned this pull request Aug 13, 2024
@maciejbaczmanski
Copy link
Contributor

@suveshpratapa #85 should allow building thread 1.4 in NCS

@suveshpratapa
Copy link
Member Author

@suveshpratapa #85 should allow building thread 1.4 in NCS

@maciejbaczmanski Can you check what could be happening? I rebased to include your merged changes and t's still failing to build NCS for 1.4.

@maciejbaczmanski
Copy link
Contributor

@suveshpratapa #85 should allow building thread 1.4 in NCS

@maciejbaczmanski Can you check what could be happening? I rebased to include your merged changes and t's still failing to build NCS for 1.4.

error can be seen here: https://github.com/openthread/ot-reference-release/actions/runs/10404358834

System.IO.IOException: No space left on device : '/home/runner/runners/2.319.1/_diag/Worker_20240815-131230-utc.log'

So it seems like a CI issue?

@jwhui
Copy link
Member

jwhui commented Aug 15, 2024

error can be seen here: https://github.com/openthread/ot-reference-release/actions/runs/10404358834

System.IO.IOException: No space left on device : '/home/runner/runners/2.319.1/_diag/Worker_20240815-131230-utc.log'

So it seems like a CI issue?

I just submitted #87, hopefully it will help.

@jwhui
Copy link
Member

jwhui commented Aug 15, 2024

@suveshpratapa , I just merged #87. Can you rebase this PR and see if it helps?

Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The CI finally passed! 🎉

@jwhui jwhui merged commit a608eb3 into openthread:main Aug 16, 2024
2 checks passed
@sunytt sunytt mentioned this pull request Aug 27, 2024
@suveshpratapa suveshpratapa deleted the task/1.4-reference-updates branch August 27, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants