Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] upgrade CMake to 3.20.2 #81

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

superwhd
Copy link
Contributor

@superwhd superwhd commented Jul 29, 2024

Fixes #80

We need to upgrade CMake because ot-commissioner has a minimum requirement of 3.20.1. The exact 3.20.1 version is not available via pip so we'll install 3.20.2.

@superwhd superwhd marked this pull request as draft July 29, 2024 02:31
@superwhd superwhd changed the title [WIP] upgrade CMake [WIP] upgrade CMake to >= 3.20.1 Jul 29, 2024
@superwhd superwhd changed the title [WIP] upgrade CMake to >= 3.20.1 [WIP] upgrade CMake to 3.20.1 Jul 29, 2024
@superwhd superwhd force-pushed the upgrade-cmake branch 8 times, most recently from 0819e4f to d0b48e7 Compare July 29, 2024 09:45
@superwhd superwhd changed the title [WIP] upgrade CMake to 3.20.1 [build] upgrade CMake to 3.20.2 Jul 29, 2024
@superwhd superwhd marked this pull request as ready for review July 29, 2024 10:41
@superwhd superwhd requested review from sunytt and jwhui July 29, 2024 14:09
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jwhui jwhui merged commit 4945ba5 into openthread:main Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing due to low CMake version
4 participants