Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/Enhancement/Custom] - Auto Loot, Quick Looting in stack and Auto Bank function #184

Merged
merged 32 commits into from
Mar 10, 2022
Merged

[Feature/Enhancement/Custom] - Auto Loot, Quick Looting in stack and Auto Bank function #184

merged 32 commits into from
Mar 10, 2022

Conversation

omeranha
Copy link
Contributor

@omeranha omeranha commented Jan 13, 2022 •
edited
Loading

Description

This PR add the best autoloot possible, using your manage loot containers quick loot categories and items filter, can be enabled in config.lua!
image

Quickloot in stack, up to 30 corpses, enabled using client option.
image

AutoBank function, the dropped coins from monsters will be automatically deposited to your bank account, can be enabled in config.lua.
image

Type of change

  • New feature (non-breaking change which adds functionality)

@omeranha omeranha changed the title QuickLooot loot in stack QuickLoot in stack Jan 13, 2022
@Aerwix
Copy link
Contributor

Aerwix commented Jan 17, 2022

Is this the same code as @hyresu proposed before?

@omeranha
Copy link
Contributor Author

Is this the same code as @hyresu proposed before?

hi, I got from this pull request: #143

@guispiller
Copy link
Contributor

As I described on discord channel, just to keep it registered:
Tested on OTBR and on canary main, quick loot in stack mechanic is working 100%, but there's a minor issue on the loot message log.
After looting a stack, the last message that shows on screen is always: "No Loot", even if you looted all corpses on the stack. It should be the message before it: "you looted x corpses".

Example on image below
unknown

@omeranha omeranha changed the title QuickLoot in stack Autoloot and quickloot stack Feb 7, 2022
@omeranha omeranha changed the title Autoloot and quickloot stack Autoloot and quickloot in stack Feb 7, 2022
@majestyotbr
Copy link
Contributor

Tested:

  • Autoloot.
  • Quickloot in stack.

@omeranha omeranha changed the title Autoloot and quickloot in stack Autoloot, Quickloot in stack and AutoBank function Feb 28, 2022
@omeranha omeranha changed the title Autoloot, Quickloot in stack and AutoBank function [Feature/Enhancement/Custom] - Auto Loot, Quick Looting in stack and Auto Bank function Feb 28, 2022
@Sh3Ns
Copy link

Sh3Ns commented Mar 8, 2022 •
edited
Loading

server crash testing in win 10 and linux , quando mata snake.

Issue in Linux #260

image
image

@omeranha omeranha mentioned this pull request Mar 9, 2022
Merged
Sh3Ns
Sh3Ns approved these changes Mar 9, 2022
View reviewed changes
Copy link

@Sh3Ns Sh3Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed Update creature.cpp

@majestyotbr majestyotbr added Status: Pending Review This PR or Issue requires a review Status: Pending Test This PR or Issue requires more testing labels Mar 9, 2022
@omeranha omeranha added Status: Completed Type: Enhancement New feature or request and removed Status: Pending Review This PR or Issue requires a review labels Mar 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@omeranha omeranha merged commit 5cb9ff7 into opentibiabr:master Mar 10, 2022
@majestyotbr majestyotbr added Review: Completed and removed Status: Pending Test This PR or Issue requires more testing labels Mar 10, 2022
@omeranha omeranha deleted the loot-in-stack branch March 10, 2022 01:50
@garaflaks
Copy link

gold in bank, does not compute in hunt analysis

omeranha added a commit to opentibiabr/otservbr-global that referenced this pull request Mar 21, 2022
@omeranha
Sync with Canary pull requests (#490)
1e6150d 
Sync with canary pull requests:
opentibiabr/canary#147
opentibiabr/canary#169
opentibiabr/canary#184
opentibiabr/canary#221
luan pushed a commit that referenced this pull request Jul 11, 2023
@omeranha
[Feature/Enhancement/Custom] - Auto Loot, Quick Looting in stack and …
52ea89d 
…Auto Bank function (#184)

Auto loot using your manage loot containers quick loot categories and items filter, can be enabled in config.lua!
Quick loot in stack, up to 30 corpses, enabled using client option.
Auto Bank function, the dropped coins from monsters will be automatically deposited to your bank account, can be enabled in config.lua.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beats-dh beats-dh beats-dh approved these changes

@Sh3Ns Sh3Ns Sh3Ns approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

@mattyx14 mattyx14 mattyx14 approved these changes

Assignees
No one assigned
Labels
Area: Source Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@omeranha @Aerwix @guispiller @majestyotbr @Sh3Ns @garaflaks @mattyx14 @beats-dh @dudantas