-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Event Scheduler #239
Merged
Merged
Fix Event Scheduler #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2022
majestyotbr
added
Status: Pending Review
This PR or Issue requires a review
Status: Pending Test
This PR or Issue requires more testing
labels
Mar 9, 2022
Costallat
force-pushed
the
main
branch
5 times, most recently
from
April 12, 2022 19:05
36d0101
to
76fd4f6
Compare
beats-dh
force-pushed
the
eventsScheduler
branch
from
April 23, 2022 05:36
a505d3e
to
1358fe0
Compare
dudantas
force-pushed
the
eventsScheduler
branch
from
April 24, 2022 17:04
1358fe0
to
cad70d5
Compare
dudantas
force-pushed
the
eventsScheduler
branch
from
April 24, 2022 18:30
cad70d5
to
0365960
Compare
Kudos, SonarCloud Quality Gate passed! |
guispiller
approved these changes
May 9, 2022
This was
linked to
issues
May 10, 2022
Closed
majestyotbr
approved these changes
May 12, 2022
majestyotbr
pushed a commit
to opentibiabr/otservbr-global
that referenced
this pull request
May 27, 2022
This works directly with: opentibiabr/canary#239
JoaoCRDias
pushed a commit
to JoaoCRDias/otservbr-global
that referenced
this pull request
Jul 27, 2022
This works directly with: opentibiabr/canary#239
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
This works directly with: opentibiabr/otservbr-global#471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Datapack Global
Area: Source
Status: Pending Review
This PR or Issue requires a review
Status: Pending Test
This PR or Issue requires more testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR works directly with: opentibiabr/otservbr-global#471
Behaviour
Actual
On login you have one "XP Gain Rate", when you get experience this value changed.
Event schedule only display info, but doesn't work.
Expected
Formulae Tibia Wiki
Fixes
configmanager.cpp & configmanager.h
RATE_USE_STAGES
boolean configrateUseStages = true
.RATE_EXPERIENCE
.spawn.cpp & spawn.h
MINSPAWN_INTERVAL
, addMonster with min value.interval
to30000
, less check time.game.cpp, scripts\luascript.cpp & protocolstatus.cpp
otserv.cpp & config.lua.dist
events.xml
NOTE: exprate, lootrate, spawnrate or skillrate in 100, it's default value.
Type of change
How Has This Been Tested
Rat Test 1: without event, rateExp x1 + stamina : 150% = 7.5
Rat Test 2: with event +100%, rateExp 100% + prey 40% + store 50% + stamina x1.5 : 435% = 21,75
Test Configuration:
Server Version:
Client: Client 12.85
Operating System: Windows 11
Checklist