Rework of checkCreatureAsKnown and fix of client debug #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beats-dh
added
Status: Pending Review
Co-Authored-By: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
beats-dh
force-pushed
the
fix-client-crash-move-diagonal
branch
from
5c20146
to
ac72e96
Compare
andersonfaaria
approved these changes
Mar 24, 2022
mattyx14
approved these changes
Mar 24, 2022
guispiller
approved these changes
Mar 26, 2022
majestyotbr
approved these changes
Apr 1, 2022
lgrossi
approved these changes
Apr 1, 2022
|
Kudos, SonarCloud Quality Gate passed! |
andersonfaaria
changed the title
dudantas
changed the title
dudantas
approved these changes
Apr 3, 2022
|
Credits fix code: Trubit Soft Sp. z o.o |
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Before, if you moved with the char diagonally for a while or even normally at a certain time, the debug client "closes unexpectedly" with this fix it doesn't happen anymore. Note: walking diagonally forces the client to debug faster. Credits fix code: Mrianura
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, if you moved with the char diagonally for a while or even normally at a certain time, the debug client "closes unexpectedly" with this fix it doesn't happen anymore.
Note: walking diagonally forces the client to debug faster.
Credits fix code:
Discord: mrianura#8150
Credits rework code:
@lgrossi
Credits for discussing the problem and testing:
@andersonfaaria
@beats-dh
@dudantas
@gccris
@lgrossi
@marcosvf132
@omeranha
Fixes Issue:
It was tested as follows:
An area with many "81k" monsters was created and we passed these monsters walking only diagonally and we had no more client debug.
Change type