[Fix] Removing unnecessary warn on item creation when id equal 0 #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
LeeoMacedo
approved these changes
May 1, 2022
dudantas
approved these changes
May 3, 2022
beats-dh
approved these changes
May 3, 2022
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Add a check on the spdlog::warn to prevent when itemID is equal 0. This happens a lot when slain a creature that has no body registered. (Regular creatures/summons/boss)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a check on the spdlog::warn to prevent when itemID is equal 0. This happens a lot when slain a creature that has no body registered. (Regular creatures/summons/boss)
Note
You may notice that there is already a check if the itemtype ID is equal 0 or not. But this is not necessary the same check because when we try to create an item that is not registered on the item protobuf binary file and on items.xml, then the itemtype will return with id == 0 but type != 0.