Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync missing weapons #405

Merged
merged 36 commits into from
Jul 19, 2022
Merged

Sync missing weapons #405

merged 36 commits into from
Jul 19, 2022

Conversation

Aerwix
Copy link
Contributor

@Aerwix Aerwix commented Jun 4, 2022

We were missing this files:

Burst Arrow
Diamond Arrow
Viper Star
Poison Arrow

P.S. I didn't checked formulas, I remember one server had excesive value with poison arrows. lol

Aerwix and others added 30 commits October 27, 2021 11:12
Magic wall wasnt decaying to 0 because it have the wrong id (2129 to 2128)
Just adding decay for the 'safe' runes of Magic Wall and Wild Growth Rune.
Safe Magic Wall isn't walkable anymore.
Adding missing code
@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@majestyotbr
Copy link
Contributor

@Aerwix
Copy link
Contributor Author

Aerwix commented Jun 8, 2022

https://github.com/opentibiabr/canary/blob/main/data/scripts/weapons/scripted_weapons.lua

Actually this is not working. Im running a clean datapack and it have that file and it's not working :) Gonna check to what's goin on there

@Aerwix
Copy link
Contributor Author

Aerwix commented Jun 8, 2022

Actually IDs are incorrect, gonna update this.
Burst Arrow is working now ✔️
Viper Star and Poison Arrow are throwing but not setting poison on target ❎
Diamond Arrow isn't shooting ❎

Also check the other repo, there are the files 🤡
https://github.com/opentibiabr/otservbr-global/tree/main/data/scripts/weapons

Image:
bugArrows

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2022

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Jul 9, 2022
@dudantas dudantas merged commit 647b005 into opentibiabr:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants