Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add max beds and house client id #8

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat: add max beds and house client id #8

merged 3 commits into from
Aug 28, 2023

Conversation

dex-89
Copy link

@dex-89 dex-89 commented Sep 14, 2021 •
edited
Loading

What's added:

  • Convert server_id to client_id (supported canary map)

New options in house's window :

  • Client ID
  • Max beds

image

@dex-89
New functions
398fdea 
Convert `server_id` to `client_id`
New house's window options:
- `Client ID`
- `Max beds`
@Aerwix
Copy link

Aerwix commented Nov 3, 2021

When it's going to happen this merge? :P

@dudantas
Copy link

When it's going to happen this merge? :P

When the server has the same system.

@majestyotbr majestyotbr deleted the branch opentibiabr:main March 25, 2023 08:10
@majestyotbr majestyotbr reopened this Mar 25, 2023
@luanluciano93
Copy link

Com as alterações que eu indiquei, funcionou ... testei mudando o valor total das camas e salvando o mapa ...
image

Posterior abrindo novamente e o valor estava correto.

image

luanluciano93
luanluciano93 reviewed Aug 10, 2023
View reviewed changes
source/iomap_otbm.cpp Outdated Show resolved Hide resolved
source/iomap_otbm.cpp Outdated Show resolved Hide resolved
@dex-89
Copy link
Author

dex-89 commented Aug 10, 2023

Com as alterações que eu indiquei, funcionou ... testei mudando o valor total das camas e salvando o mapa ... image

Posterior abrindo novamente e o valor estava correto.

image

@dudantas what do you think about changes?

dudantas and others added 2 commits August 10, 2023 09:57
@dudantas @luanluciano93
Update source/iomap_otbm.cpp
32f819a 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@dudantas @luanluciano93
Update source/iomap_otbm.cpp
5e9160a 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@dudantas
Copy link

dudantas commented Aug 10, 2023 •
edited
Loading

Com as alterações que eu indiquei, funcionou ... testei mudando o valor total das camas e salvando o mapa ... image
Posterior abrindo novamente e o valor estava correto.
image

@dudantas what do you think about changes?

Honestly, it's up to you. When it's ok, let me know and I'll merge it.

@luanluciano93
Copy link

luanluciano93 commented Aug 11, 2023 •
edited
Loading

Fiz um teste no jogo, não sei se tem alguma relação .. mas define o máximo de camas 2.

image

<house name="Baiak City #1" houseid="1" entryx="1080" entryy="1036" entryz="7" rent="0" townid="1" size="24" clientid="0" beds="2" />

@luanluciano93
Copy link

@dex-89, excuse my ignorance, but what is this "client id" option for in houses?

@dex-89
Copy link
Author

dex-89 commented Aug 26, 2023

@dex-89, excuse my ignorance, but what is this "client id" option for in houses?

Client id - House id from original (Cipsoft's) Tibia client

@luanluciano93
Copy link

luanluciano93 commented Aug 26, 2023 •
edited
Loading

@dex-89 Wouldn't another name be more understandable?

@dex-89
Copy link
Author

dex-89 commented Aug 26, 2023

@dex-89 Wouldn't another name be more understandable?

Possibly yes, but this is a very old project of mine that I no longer work on. Write to @dudantas about this

@luanluciano93
Copy link

luanluciano93 commented Aug 26, 2023 •
edited
Loading

@dex-89 Can I create a PR with just the Max beds part? Once the canary supports "client id", we can add...

@dudantas dudantas changed the title New functions feat: add max beds and house client id Aug 28, 2023
@dudantas dudantas merged commit 42bb101 into opentibiabr:main Aug 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanluciano93 luanluciano93 luanluciano93 left review comments

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dex-89 @Aerwix @dudantas @luanluciano93 @majestyotbr